Fix running protoc#21
Closed
kolyshkin wants to merge 1 commit into
Closed
Conversation
A recent commit caused a regression: > protoc --decode google.protobuf.FileDescriptorSet /usr/local/include/google/protobuf/descriptor.proto > /usr/local/include/google/protobuf/descriptor.proto: File does not reside within any path specified using --proto_path (or -I). You must specify a --proto_path which encompasses this file. Note that the proto_path must be an exact prefix of the .proto file names -- protoc is too dumb to figure out when two paths (e.g. absolute and relative) are equivalent (it's harder than you think). Although I can't seem to reproduce it locally, it is clear that protoc do require --proto_path in this case. Add it back. Fixes: 95af7b7 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
@stevvooe PTAL |
Contributor
Author
|
Maybe it's not needed for protoc 3.6.1, but it def fails with 3.5.0 |
Contributor
Author
Contributor
Author
Indeed it works fine with 3.6.1: |
Contributor
Author
|
This looks ugly, and is not needed for protoc 3.6.1, so feel free to close |
Member
|
@kolyshkin Let me know if that changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent commit (PR #20) caused a regression:
Although I can't seem to reproduce it locally, it is clear that
protoc do require --proto_path in this case. Add it back.
Fixes: 95af7b7